Skip to content

tools: prohibit Error.prepareStackTrace usage #29827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

tools: prohibit Error.prepareStackTrace usage #29827

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6b7a6
tools: prohibit Error.prepareStackTrace usage
BridgeAR Oct 3, 2019
620cd30
fixup
BridgeAR Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: prohibit Error.prepareStackTrace usage 
This eslint rule makes sure that `prepareStackTrace` is not used in
Node.js core.
  • Loading branch information
@BridgeAR
BridgeAR committed Oct 3, 2019
commit db6b7a609a27062098e90d56e0415a6fb8c4d4bc
2 changes: 2 additions & 0 deletions lib/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ rules:
message: "Use an error exported by the internal/errors module."
- selector: "CallExpression[callee.object.name='Error'][callee.property.name='captureStackTrace']"
message: "Please use `require('internal/errors').hideStackFrames()` instead."
- selector: "AssignmentExpression:matches([left.name='prepareStackTrace'], [left.property.name='prepareStackTrace'])"
message: "Please use 'internalOverriddenErrors' from 'lib/internal/errors.js' instead of 'Error.prepareStackTrace'."
Comment thread
BridgeAR marked this conversation as resolved.
Outdated
# Custom rules in tools/eslint-rules
node-core/lowercase-name-for-primitive: error
node-core/non-ascii-character: error
Expand Down