Skip to content

stream: always invoke end(cb) callback #29747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 9 commits into from
Closed

stream: always invoke end(cb) callback #29747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ee5a19a
stream: always invoke end callback
ronag Sep 28, 2019
40d2140
fixup: propagate to uncaught
ronag Oct 2, 2019
ffbff6c
fixup: add test for uncaugth
ronag Oct 2, 2019
0162b1c
fixup: use on
ronag Oct 2, 2019
c00303f
fixup: linting
ronag Oct 2, 2019
e041ae3
fixup: another deadlock case
ronag Oct 6, 2019
f71dcd9
fixup: don't use EE.listenerCount
ronag Oct 7, 2019
aee2077
fixup: prepend error listener + test
ronag Oct 11, 2019
0a482b7
fixup: fix finish order
ronag Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: prepend error listener + test
  • Loading branch information
@ronag
ronag committed Oct 11, 2019
commit aee2077b961c84e9f01653bbe640b0b277c0508a
4 changes: 2 additions & 2 deletions lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,8 +727,8 @@ function onFinished(stream, state, cb) {
stream.removeListener('error', onerror);
cb();
}
stream.on('finish', onfinish);
stream.on('error', onerror);
stream.prependListener('finish', onfinish);
stream.prependListener('error', onerror);
}
Comment thread
ronag marked this conversation as resolved.
Outdated

Object.defineProperty(Writable.prototype, 'destroyed', {
Expand Down
16 changes: 16 additions & 0 deletions test/parallel/test-stream-writable-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,3 +328,19 @@ const assert = require('assert');
}));
write.end();
}

{
// Call end(cb) after error & destroy and don't trigger
// unhandled exception.

const write = new Writable({
write(chunk, enc, cb) { process.nextTick(cb); }
});
write.once('error', common.mustCall((err) => {
assert.strictEqual(err.message, 'asd');
}));
write.end('asd', common.mustCall((err) => {
assert.strictEqual(err.message, 'asd');
}));
write.destroy(new Error('asd'));
}