Skip to content

module: move cjs type check behind experimental-modules flag #29732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 2 commits into from
Closed

module: move cjs type check behind experimental-modules flag #29732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6849866
module: move cjs type check behind flag
guybedford Sep 27, 2019
36cb1d1
switch flag logical order
guybedford Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
module: move cjs type check behind flag
  • Loading branch information
@guybedford
guybedford committed Sep 27, 2019
commit 68498665fc512a77e96155b53da2faa094adebdb
2 changes: 1 addition & 1 deletion lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ Module.prototype._compile = function(content, filename) {

// Native extension for .js
Module._extensions['.js'] = function(module, filename) {
if (filename.endsWith('.js')) {
if (filename.endsWith('.js') && experimentalModules) {
Comment thread
guybedford marked this conversation as resolved.
Outdated
const pkg = readPackageScope(filename);
if (pkg && pkg.type === 'module') {
throw new ERR_REQUIRE_ESM(filename);
Expand Down
1 change: 1 addition & 0 deletions test/es-module/test-esm-type-flag-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Flags: --experimental-modules
'use strict';
const common = require('../common');
const assert = require('assert');
Expand Down