Skip to content

build: remove unused libatomic and librt on ppc64, s390x #29727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 2 commits into from
Closed

build: remove unused libatomic and librt on ppc64, s390x #29727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2d50ab
build: remove unused libatomic on ppc64, s390x
sam-github Sep 26, 2019
3bfdb93
build: do not link against librt on linux
sam-github Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: remove unused libatomic on ppc64, s390x 
The library is not necessary for ppc64 or s390x. It does no harm with
some linkers, but devtoolset-6 creates runtime dependencies on all link
libraries, even unused ones.

Fixes: #27377
Fixes: #29718
  • Loading branch information
@sam-github
sam-github committed Oct 1, 2019
commit e2d50ab52249ef4b965be2ca1ccad39d5b44ff9c
2 changes: 1 addition & 1 deletion tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@
}],
# Platforms that don't have Compare-And-Swap (CAS) support need to link atomic library
# to implement atomic memory access
['v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc", "ppc64", "s390x"]', {
['v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc"]', {
'link_settings': {
'libraries': ['-latomic', ],
},
Expand Down