Skip to content

http: add reusedSocket property on client request #29715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
themez wants to merge 4 commits into from
Closed

http: add reusedSocket property on client request #29715

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21ef016
http: add reusedSocket property on client request
themez Sep 26, 2019
f198794
add tests and docs
themez Oct 1, 2019
ebf41bf
fix lint
themez Oct 1, 2019
cd3ed01
fix doc version
themez Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
@themez
themez committed Oct 12, 2019
commit ebf41bfe36332d208fe359fbeefbd0f03d0bdccb
6 changes: 3 additions & 3 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ might be reused. But if server closes connection at unfortunate time, client
may run into a 'ECONNRESET' error.

```js
const http = require('http')
const http = require('http');

// Server has a 5 seconds keep-alive timeout by default
http
Expand All @@ -702,10 +702,10 @@ http
setInterval(() => {
// Adapting a keep-alive agent
http.get('http://localhost:3000', { agent }, (res) => {
res.on('data', data => {
res.on('data', (data) => {
// Do nothing
});
})
});
}, 5000); // Sending request on 5s interval so it's easy to hit idle timeout
```

Expand Down