Skip to content

errors: make sure all Node.js errors show their properties #29677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

errors: make sure all Node.js errors show their properties #29677

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa3b02b
errors: make sure all Node.js errors show their properties
BridgeAR Sep 23, 2019
f9d8303
errors: add todo comment to investigate SystemError properties
BridgeAR Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
errors: add todo comment to investigate SystemError properties 
It is not clear why some operations are done in a specific way. This
should be clarified to potentially simplify the implementation.
  • Loading branch information
@BridgeAR
BridgeAR committed Oct 1, 2019
commit f9d8303a8693e5f85311a7feefa10b845ef92643
5 changes: 5 additions & 0 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ class SystemError extends Error {
});

if (context.path !== undefined) {
// TODO(BridgeAR): Investigate why and when the `.toString()` was
// introduced. The `path` and `dest` properties in the context seem to
// always be of type string. We should probably just remove the
// `.toString()` and `Buffer.from()` operations and set the value on the
// context as the user did.
Object.defineProperty(this, 'path', {
get() {
return context.path != null ?
Expand Down