Skip to content

src: fix closing weak HandleWraps on GC #29640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
+7 −2
Closed

src: fix closing weak HandleWraps on GC #29640

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20aae9d
src: fix closing weak `HandleWrap`s on GC
addaleax Sep 21, 2019
9e45a59
fixup! src: fix closing weak `HandleWrap`s on GC
addaleax Sep 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: fix closing weak HandleWraps on GC 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317
  • Loading branch information
@addaleax
addaleax committed Sep 21, 2019
commit 20aae9d94adca943d9bea41eecddd370ae04f067
4 changes: 2 additions & 2 deletions src/handle_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ void HandleWrap::Close(Local<Value> close_callback) {
if (state_ != kInitialized)
return;

CHECK_EQ(false, persistent().IsEmpty());
uv_close(handle_, OnClose);
state_ = kClosing;

if (!close_callback.IsEmpty() && close_callback->IsFunction()) {
if (!close_callback.IsEmpty() && close_callback->IsFunction() &&
!persistent().IsEmpty()) {
object()->Set(env()->context(),
env()->handle_onclose_symbol(),
close_callback).Check();
Expand Down
3 changes: 3 additions & 0 deletions test/sequential/test-performance-eventloopdelay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Flags: --expose-gc
'use strict';

const common = require('../common');
Expand Down Expand Up @@ -97,3 +98,5 @@ const {
}
spinAWhile();
}

process.on('exit', global.gc);
Comment thread
addaleax marked this conversation as resolved.