Skip to content

[v8.x] Backport aix test fixes to v8.x #29599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewhughes101 wants to merge 5 commits into from
Closed

[v8.x] Backport aix test fixes to v8.x #29599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84e4d05
test: skip tests related to CI failures on AIX
sam-github Jun 28, 2019
3ebdd70
test: skip stringbytes-external-exceed-max on AIX
sam-github Jul 2, 2019
f8b2ffd
test: fix pty test hangs on aix
bnoordhuis Jul 8, 2019
3c5a25f
test: specialize OOM check for AIX
sam-github Jul 24, 2019
9209f48
test: unskip tests that now pass on AIX
sam-github Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: skip tests related to CI failures on AIX 
These tests seem to trigger failures in the entire CI job (not just the
test) on AIX. Skip them to see if that helps alleviate spurious failures
in node-test-commit-aix (and the upstream PR and commit test jobs).

See:
- nodejs/build#1820 (comment)
- nodejs/build#1847 (comment)

PR-URL: #28469
Backport-PR-URL: #29599
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@sam-github @andrewhughes101
sam-github authored and andrewhughes101 committed Sep 18, 2019
commit 84e4d056ca172c09bf79fe98e9be7c8995c20e06
5 changes: 5 additions & 0 deletions test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem)
common.skip(skipMessage);

// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
// See https://github.com/nodejs/node/pull/28469
if (process.platform === 'aix')
common.skip('flaky on AIX');

const binding = require(`./build/${common.buildType}/binding`);
const assert = require('assert');

Expand Down
3 changes: 3 additions & 0 deletions test/message/message.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ prefix message

[$system==freebsd]

[$system==aix]
Comment thread
andrewhughes101 marked this conversation as resolved.
# https://github.com/nodejs/node/pull/28469
vm_dont_display_syntax_error: SKIP
4 changes: 4 additions & 0 deletions test/pseudo-tty/pseudo-tty.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ prefix pseudo-tty
[$system==aix]
# being investigated under https://github.com/nodejs/node/issues/9728
test-tty-wrap : FAIL, PASS
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
# https://github.com/nodejs/node/pull/28469
console-dumb-tty: SKIP
test-fatal-error: SKIP

[$system==solaris]
# https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems
Expand Down
3 changes: 3 additions & 0 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ test-http2-settings-flood: PASS,FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
test-async-wrap-getasyncid: SKIP
test-buffer-creation-regression: SKIP