Skip to content

test: fix flaky test-inspector-connect-main-thread #29588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

test: fix flaky test-inspector-connect-main-thread #29588

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ecc406
doc: update experimental loader hooks example code
zaverden Aug 30, 2019
b1314e0
test: fix flaky test-inspector-connect-main-thread
addaleax Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix flaky test-inspector-connect-main-thread 
Using `console.log()` likely interferes with the functionality of the
test, which also checks the interaction between inspector
and `console.log()` as part of the test. Using `process._rawDebug()`
solves that issue.

Refs: #28870
Refs: #29582
  • Loading branch information
@addaleax
addaleax committed Sep 17, 2019
commit b1314e03f156b7a570ff34d7949f48e86b393204
4 changes: 2 additions & 2 deletions test/parallel/test-inspector-connect-main-thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ async function post(session, method, params) {
session.post(method, params, (error, success) => {
messagesSent.push(method);
if (error) {
console.log(`Message ${method} produced an error`);
process._rawDebug(`Message ${method} produced an error`);
reject(error);
} else {
console.log(`Message ${method} was sent`);
process._rawDebug(`Message ${method} was sent`);
resolve(success);
}
});
Expand Down