Skip to content

process: add source-map support to stack traces #29564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 8 commits into from
Closed

process: add source-map support to stack traces #29564

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45a15de
process: add source-map support to stack traces
Sep 29, 2019
85855fb
test: path.sep, my old foe
Sep 29, 2019
c0ae2ed
chore: missed one /
Sep 29, 2019
afcef58
chore: address bug when running with coverage enabled
Sep 29, 2019
dd99ec7
chore: don't step on toes of internal stack-trace generation
Oct 4, 2019
1884dbf
chore: add todo note
Oct 4, 2019
baf9e9d
Update lib/internal/source_map/source_map.js
Oct 4, 2019
ae47642
chore: address code review
Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: don't step on toes of internal stack-trace generation
  • Loading branch information
bcoe committed Oct 5, 2019
commit dd99ec7e9cd27bda148b6a8c382821ecd718b0f7
10 changes: 10 additions & 0 deletions lib/internal/source_map/source_map_cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const cjsSourceMapCache = new WeakMap();
// on filenames.
const esmSourceMapCache = new Map();
const { fileURLToPath, URL } = require('url');
const { overrideStackTrace } = require('internal/errors');

let experimentalSourceMaps;
function maybeCacheSourceMap(filename, content, cjsModuleInstance) {
Expand Down Expand Up @@ -173,6 +174,15 @@ const prepareStackTrace = (globalThis, error, trace) => {
const { SourceMap } = require('internal/source_map/source_map');
const ErrorToString = Error.prototype.toString;
const errorString = ErrorToString.call(error);

// API for node internals to override error stack formatting
// without interfering with userland code.
if (overrideStackTrace.has(error)) {
const f = overrideStackTrace.get(error);
overrideStackTrace.delete(error);
return f(error, trace);
}

if (trace.length === 0) {
return errorString;
}
Expand Down