Skip to content

inspector: update faviconUrl #29562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dokugo wants to merge 2 commits into from
Closed

inspector: update faviconUrl #29562

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5037009
inspector: update faviconUrl
dokugo Sep 15, 2019
4d96d3b
inspector: linter fix
dokugo Sep 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
inspector: update faviconUrl
  • Loading branch information
@dokugo
dokugo committed Sep 15, 2019
commit 5037009523628a54ab0ff0440d37a0c31157be7a
2 changes: 1 addition & 1 deletion src/inspector_socket_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket,
response.push_back(std::map<std::string, std::string>());
std::map<std::string, std::string>& target_map = response.back();
target_map["description"] = "node.js instance";
target_map["faviconUrl"] = "https://nodejs.org/static/favicon.ico";
target_map["faviconUrl"] = "https://nodejs.org/static/images/favicons/favicon.ico";
target_map["id"] = id;
target_map["title"] = delegate_->GetTargetTitle(id);
Escape(&target_map["title"]);
Expand Down