Skip to content

src: print exceptions from PromiseRejectCallback #29513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

src: print exceptions from PromiseRejectCallback #29513

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dad1391
src: print exceptions from PromiseRejectCallback
addaleax Sep 9, 2019
b990248
fixup! src: print exceptions from PromiseRejectCallback
addaleax Sep 12, 2019
b236ffb
fixup! src: print exceptions from PromiseRejectCallback
addaleax Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src: print exceptions from PromiseRejectCallback
  • Loading branch information
@addaleax
addaleax committed Sep 12, 2019
commit b990248fb9f23085ef3d39db19ba1c1577d81e24
2 changes: 1 addition & 1 deletion test/parallel/test-async-wrap-pop-id-during-load.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ assert.strictEqual(ret.status, 0,
`EXIT CODE: ${ret.status}, STDERR:\n${ret.stderr}`);
const stderr = ret.stderr.toString('utf8', 0, 2048);
assert.ok(!/async.*hook/i.test(stderr));
assert.ok(stderr.includes('UnhandledPromiseRejectionWarning: Error'), stderr);
assert.ok(stderr.includes('Maximum call stack size exceeded'), stderr);
10 changes: 5 additions & 5 deletions test/parallel/test-promise-reject-callback-exception.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
const common = require('../common');
require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const path = require('path');
Expand All @@ -21,11 +21,11 @@ for (const NODE_V8_COVERAGE of ['', tmpdir.path]) {
{ env: { ...process.env, NODE_V8_COVERAGE } });

assert(stdout.toString('utf8')
.startsWith('RangeError: Maximum call stack size exceeded'),
`stdout: <${stdout}>`);
.startsWith('RangeError: Maximum call stack size exceeded'),
`stdout: <${stdout}>`);
assert(stderr.toString('utf8')
.startsWith('Exception in PromiseRejectCallback'),
`stderr: <${stderr}>`);
.startsWith('Exception in PromiseRejectCallback'),
`stderr: <${stderr}>`);
assert.strictEqual(status, 0);
assert.strictEqual(signal, null);
}