Skip to content

events: add/removeListener should call on/off #29503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 7 commits into from
Closed

events: add/removeListener should call on/off #29503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93e6b3f
events: add/removeListener should call on/off
ronag Sep 9, 2019
cae69fd
fixup: linting
ronag Sep 9, 2019
a41b352
fixup: docs
ronag Sep 9, 2019
ef8ec59
fixup: make off/on primary
ronag Sep 9, 2019
6fb1004
fixup: linting & test
ronag Sep 9, 2019
1dabd38
fixup: linting
ronag Sep 9, 2019
7f45190
fixup: on/removeListener
ronag Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: linting
  • Loading branch information
@ronag
ronag committed Sep 9, 2019
commit cae69fd9c2ced70e0940b7b46a3b13f80f8baf5e
8 changes: 4 additions & 4 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ EventEmitter.prototype.addListener = function addListener(type, listener) {
return _addListener(this, type, listener, false);
};

EventEmitter.prototype.on = function (type, listener) {
EventEmitter.prototype.on = function(type, listener) {
this.addListener(type, listener);
}
};

EventEmitter.prototype.prependListener =
function prependListener(type, listener) {
Expand Down Expand Up @@ -380,9 +380,9 @@ EventEmitter.prototype.removeListener =
return this;
};

EventEmitter.prototype.off = function (type, listener) {
EventEmitter.prototype.off = function(type, listener) {
this.removeListener(type, listener);
}
};

EventEmitter.prototype.removeAllListeners =
function removeAllListeners(type) {
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-events-override.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';

const common = require('../common');
const { once, EventEmitter: EE } = require('events');
const { strictEqual, deepStrictEqual } = require('assert');
const { EventEmitter: EE } = require('events');

{
const e = new EE();
Expand Down