Skip to content

module: package exports dot main support #29494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 4 commits into from
Closed

module: package exports dot main support #29494

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddc030c
module: package exports dot main
guybedford Sep 8, 2019
a9e9bb5
linting fix
guybedford Sep 8, 2019
690237d
Update doc/api/esm.md
guybedford Sep 8, 2019
9f7bc64
Update doc/api/esm.md
guybedford Sep 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linting fix
  • Loading branch information
@guybedford
guybedford committed Sep 8, 2019
commit a9e9bb5cf519aaaf6bd0869be6f3bc9b56174a45
3 changes: 2 additions & 1 deletion src/module_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,8 @@ Maybe<URL> PackageMainResolve(Environment* env,
Local<Object> exports_obj = exports.As<Object>();
Local<String> dot_string = String::NewFromUtf8(env->isolate(), ".",
v8::NewStringType::kNormal).ToLocalChecked();
target = exports_obj->Get(env->context(), dot_string).ToLocalChecked();
target =
exports_obj->Get(env->context(), dot_string).ToLocalChecked();
}
if (target->IsString()) {
Copy link
Copy Markdown
Contributor

@hybrist hybrist Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to reuse the existing logic for string/array in PackageExportsResolve?

Copy link
Copy Markdown
Contributor Author

@guybedford guybedford Sep 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be better, it's just a refactoring I haven't had the time for. Would you be ok with moving that to a follow-up?

Copy link
Copy Markdown
Contributor

@hybrist hybrist Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Utf8Value target_utf8(isolate, target.As<v8::String>());
Expand Down