Skip to content

deps: update V8 to 7.8 #29493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzokuken wants to merge 15 commits into from
Closed

deps: update V8 to 7.8 #29493

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c279d62
deps: update V8 to 7.8.279.2
ryzokuken Sep 8, 2019
937d428
build: reset embedder string to "-node.0"
ryzokuken Sep 8, 2019
781ea59
src: update NODE_MODULE_VERSION to 79
ryzokuken Sep 8, 2019
933f2a7
deps: V8: fix filename manipulation for Windows
refack Mar 31, 2019
3333224
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
9a8d072
deps: V8: silence irrelevant warning
targos Mar 27, 2019
5b62519
deps: V8: patch register-arm64.h
refack May 22, 2019
d045559
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
b1450a3
deps: V8: use ATOMIC_VAR_INIT instead of std::atomic_init
refack May 23, 2019
d6ed35e
deps: V8: add workaround for MSVC optimizer bug
refack May 17, 2019
4ebaafd
deps: V8: fix BUILDING_V8_SHARED issues
refack May 26, 2019
2030aa4
deps: V8: fix linking issue for MSVS
refack May 30, 2019
c19fbb1
tools: update V8 gypfiles
targos Aug 19, 2019
b36a837
assert: fix it
targos Aug 28, 2019
246e56f
tools: patch V8 to make sure it runs on older XCode versions
ryzokuken Sep 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: add workaround for MSVC optimizer bug 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
@refack @ryzokuken
refack authored and ryzokuken committed Sep 8, 2019
commit d6ed35e7c07c1773cff61d28e5f6bca5cc2b1529
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.6',
'v8_embedder_string': '-node.7',

##### V8 defaults for Node.js #####

Expand Down
9 changes: 9 additions & 0 deletions deps/v8/src/builtins/setup-builtins-internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,10 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index,

} // namespace

#ifdef _MSC_VER
#pragma optimize( "", off )
#endif

// static
void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
Builtins* builtins = isolate->builtins();
Expand Down Expand Up @@ -353,5 +357,10 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
builtins->MarkInitialized();
}

#ifdef _MSC_VER
#pragma optimize( "", on )
#endif


} // namespace internal
} // namespace v8