Skip to content

Partially revert "stream: reduce internal usage of public require of util" #29475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

Partially revert "stream: reduce internal usage of public require of util" #29475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Partially revert "stream: reduce internal usage of public require of … 
…util"

This partially reverts commit c97851d.

Streams code should ideally require on public APIs as much as possible,
because it is exported as readable-stream.

Refs: #26698
Refs: nodejs/readable-stream#416
  • Loading branch information
@addaleax
addaleax committed Sep 6, 2019
commit 2cde79b206477409fbe38189e3346aebd885afee
2 changes: 1 addition & 1 deletion lib/internal/streams/buffer_list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const { Buffer } = require('buffer');
const { inspect } = require('internal/util/inspect');
const { inspect } = require('util');

module.exports = class BufferList {
constructor() {
Expand Down
2 changes: 1 addition & 1 deletion lib/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Stream.Stream = Stream;

// Internal utilities
try {
const types = require('internal/util/types');
const types = require('util').types;
if (types && typeof types.isUint8Array === 'function') {
Stream._isUint8Array = types.isUint8Array;
} else {
Expand Down