Skip to content

doc: simply wording in n-api doc #29441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 3 commits into from
Closed

doc: simply wording in n-api doc #29441

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc08422
doc: simply wording in n-api doc
mhdawson Sep 4, 2019
bf69aab
Update doc/api/n-api.md
mhdawson Sep 5, 2019
6448878
Update doc/api/n-api.md
mhdawson Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api/n-api.md 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@mhdawson @Trott
mhdawson and Trott authored Sep 5, 2019
commit bf69aabac48d7ad421645ef18454e3cdfb9343e4
2 changes: 1 addition & 1 deletion doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ typedef void (*napi_async_execute_callback)(napi_env env, void* data);
```

Implementations of this function must avoid making N-API calls
that result in the execution of JavaScript or interaction with
that execute JavaScript or interact with
JavaScript objects. Any code that needs to make N-API
Comment thread
mhdawson marked this conversation as resolved.
Outdated
calls should be in the `napi_async_complete_callback` instead.
Do not use the `napi_env` parameter as it will likely
Expand Down