Skip to content

gyp: make StringIO work in ninja.py #29414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cclauss wants to merge 2 commits into from
Closed

gyp: make StringIO work in ninja.py #29414

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc96822
gyp: make StringIO work in ninja.py
cclauss Sep 3, 2019
e572d2c
fixup! Use Google-style indentation
cclauss Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gyp: make StringIO work in ninja.py 
Allow both Python 2 and 3 to access StringIO
  • Loading branch information
@cclauss
cclauss authored Sep 3, 2019
commit cc96822d83ebeb522f7d0f4c2a68f52bd8689219
5 changes: 4 additions & 1 deletion tools/gyp/pylib/gyp/generator/ninja.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
import gyp.msvs_emulation
import gyp.MSVSUtil as MSVSUtil
import gyp.xcode_emulation
from io import StringIO
try:
from cStringIO import StringIO
except ImportError:
from io import StringIO

from gyp.common import GetEnvironFallback
import gyp.ninja_syntax as ninja_syntax
Expand Down