Skip to content

stream: don't deadlock on aborted stream #29376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

stream: don't deadlock on aborted stream #29376

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9cf719
stream: don't deadlock on aborted stream
ronag Aug 30, 2019
6a3ebdd
fixup: comments
ronag Aug 30, 2019
0bd77cd
fixup: linting
ronag Aug 31, 2019
523eb04
fixup: linting
ronag Sep 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: linting
  • Loading branch information
@ronag
ronag committed Aug 31, 2019
commit 0bd77cdf45661c12089e95e0abd405a63b530822
12 changes: 6 additions & 6 deletions test/parallel/test-http-client-finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@ const http = require('http');
const { finished } = require('stream')

{
// abort before finished
// Test abort before finished.

const server = http.createServer(function(req, res) {
res.write('asd')
res.write('asd');
});

server.listen(0, common.mustCall(function() {
const req = http.request({
http.request({
port: this.address().port
})
.on('response', res => {
res.on('readable', () => (
res.destroy()
));
res.on('readable', () => {
res.destroy();
});
finished(res, common.mustCall(() => {
server.close();
}));
Expand Down