Skip to content

v12.9.1 release proposal #29321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 8 commits into from
Aug 26, 2019
Merged

v12.9.1 release proposal #29321

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f8f8754
Revert "http: reset parser.incoming when server response is finished"
mcollina Aug 22, 2019
3c7a1a9
test, http: add regression test for keepalive 'end' event
mcollina Aug 22, 2019
ff6330a
test: fix 'timeout' typos
cjihrig Aug 20, 2019
3cc8fca
crypto: handle i2d_SSL_SESSION() error return
bnoordhuis Aug 20, 2019
dedbd11
http: fix event listener leak
Aug 21, 2019
a6abfcb
src: remove unused using declarations
danbev Aug 20, 2019
ae0a0e9
http: reset parser.incoming when server request is finished
addaleax Aug 24, 2019
9cfb384
2019-08-26, Version 12.9.1 (Current)
targos Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix 'timeout' typos 
I don't think so, Tim.

PR-URL: #29234
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@cjihrig @targos
cjihrig authored and targos committed Aug 26, 2019
commit ff6330a6ac305fda67cab6ddfa87bb2e7e7785c7
2 changes: 1 addition & 1 deletion test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ function canCreateSymLink() {
'System32', 'whoami.exe');

try {
const output = execSync(`${whoamiPath} /priv`, { timout: 1000 });
const output = execSync(`${whoamiPath} /priv`, { timeout: 1000 });
return output.includes('SeCreateSymbolicLinkPrivilege');
} catch {
return false;
Expand Down
2 changes: 1 addition & 1 deletion test/common/tmpdir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function rimrafSync(pathname, { spawn = true } = {}) {
if (spawn && process.platform === 'win32' && st.isDirectory()) {
try {
// Try `rmdir` first.
execSync(`rmdir /q /s ${pathname}`, { timout: 1000 });
execSync(`rmdir /q /s ${pathname}`, { timeout: 1000 });
} catch (e) {
// Attempt failed. Log and carry on.
debug(e);
Expand Down