Skip to content

lib: add ASCII fast path to getStringWidth() #29301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

lib: add ASCII fast path to getStringWidth() #29301

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e2e2ef
lib: add ASCII fast path to getStringWidth()
addaleax Aug 25, 2019
9f726cb
fixup! lib: add ASCII fast path to getStringWidth()
addaleax Aug 25, 2019
8afd07e
fixup! lib: add ASCII fast path to getStringWidth()
addaleax Aug 25, 2019
1a90c4c
fixup! lib: add ASCII fast path to getStringWidth()
addaleax Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! lib: add ASCII fast path to getStringWidth()
  • Loading branch information
@addaleax
addaleax committed Aug 25, 2019
commit 9f726cbb54756684580a7fb5f15704573d35b90a
3 changes: 2 additions & 1 deletion lib/internal/readline/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ if (internalBinding('config').hasIntl) {
getStringWidth = function getStringWidth(str, options) {
options = options || {};
if (Number.isInteger(str)) {
// Provide information about the character with code point 'str'.
return icu.getStringWidth(
str,
Boolean(options.ambiguousAsFullWidth),
Boolean(options.expandEmojiSequence)
false
);
Comment thread
bnoordhuis marked this conversation as resolved.
}
str = stripVTControlCharacters(String(str));
Expand Down