Skip to content

crypto: add support for IEEE-P1363 DSA signatures #29292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 3 commits into from
Closed

crypto: add support for IEEE-P1363 DSA signatures #29292

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83ef2e3
crypto: add support for IEEE-P1363 DSA signatures
tniessen Aug 20, 2019
9caf740
test: add dsaEncoding compatibility test
tniessen Sep 2, 2019
65dfd30
crypto: fix memory leak in sign()
tniessen Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add dsaEncoding compatibility test 
This adds a test case for the dsaEncoding option using data generated
in Chrome 76.
  • Loading branch information
@tniessen
tniessen committed Nov 19, 2019
commit 9caf740905107dcc87ad6022bd61d92a27e59d37
16 changes: 16 additions & 0 deletions test/parallel/test-crypto-sign-verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,22 @@ common.expectsError(
}
}

// Test verifying externally signed messages.
const extSig = Buffer.from('494c18ab5c8a62a72aea5041966902bcfa229821af2bf65' +
'0b5b4870d1fe6aebeaed9460c62210693b5b0a300033823' +
'33d9529c8abd8c5948940af944828be16c', 'hex');
for (const ok of [true, false]) {
assert.strictEqual(
crypto.verify('sha256', data, {
key: fixtures.readKey('ec-key.pem'),
dsaEncoding: 'ieee-p1363'
}, extSig),
ok
);

extSig[Math.floor(Math.random() * extSig.length)] ^= 1;
}

// Non-(EC)DSA keys should ignore the option.
const sig = crypto.sign('sha1', data, {
key: keyPem,
Expand Down