Skip to content

module: avoid passing unnecessary loop reference #29275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saghul wants to merge 1 commit into from
Closed

module: avoid passing unnecessary loop reference #29275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
module: avoid passing unnecessary loop reference 
It's a sync request, which doesn't require the loop parameter to be set.
  • Loading branch information
@saghul
saghul committed Aug 22, 2019
commit ac00eb44aaf5a425e2859ab4164020f38e7e0177
2 changes: 1 addition & 1 deletion src/module_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ std::string ReadFile(uv_file file) {
uv_buf_t buf = uv_buf_init(buffer_memory, sizeof(buffer_memory));

do {
const int r = uv_fs_read(uv_default_loop(),
const int r = uv_fs_read(nullptr,
&req,
file,
&buf,
Expand Down