Skip to content

fix fs.read documentation typo read instead of write #29270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HACHIMIam wants to merge 5 commits into from
Closed

fix fs.read documentation typo read instead of write #29270

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58c2ab7
fix fs.read documentation typo read instead of write
hachimiSfeir Aug 22, 2019
2fa552c
Update doc/api/fs.md
HACHIMIam Aug 22, 2019
9c6068d
Update doc/api/fs.md
HACHIMIam Aug 27, 2019
a6387e4
keep writing at in offset params in fs.read
hachimiSfeir Jan 12, 2020
6e2ab87
reduce fs.read buffer line size
hachimiSfeir Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api/fs.md 
Co-Authored-By: Anna Henningsen <github@addaleax.net>
  • Loading branch information
@HACHIMIam @addaleax
HACHIMIam and addaleax authored Aug 27, 2019
commit 9c6068d11e75525e4f3df6653bec0205a1baeb1b
2 changes: 1 addition & 1 deletion doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2503,7 +2503,7 @@ changes:

Read data from the file specified by `fd`.

`buffer` is the buffer that the data will be read from.
`buffer` is the buffer that the data which was read from the fd will be written to.
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Jan 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line exceeds the maximum allowed line length.

Suggested change
`buffer` is the buffer that the data which was read from the fd will be written to.
`buffer` is the buffer that the data which was read from the fd will be written
to.

Copy link
Copy Markdown
Author

@HACHIMIam HACHIMIam Jan 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR i tried reduce the line length


`offset` is the offset in the buffer to start reading from.
Comment thread
HACHIMIam marked this conversation as resolved.
Outdated

Expand Down