Skip to content

http: make sure end is always emitted with keepalive connections #29263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 2 commits into from
Closed

http: make sure end is always emitted with keepalive connections #29263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eb3ce3
Revert "http: reset parser.incoming when server response is finished"
mcollina Aug 22, 2019
3bef00e
test, http: add regression test for keepalive 'end' event
mcollina Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test, http: add regression test for keepalive 'end' event 
This test covers a regression where 'end' was not emitted in the case
of keepalive requests without parsing the full body.
  • Loading branch information
@mcollina
mcollina committed Aug 22, 2019
commit 3bef00e8b6e89df22d1b6ef9e5b7478551ae6148
29 changes: 29 additions & 0 deletions test/parallel/test-http-server-keepalive-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
'use strict';

const common = require('../common');
const { createServer } = require('http');
const { connect } = require('net');

const server = createServer(common.mustCall((req, res) => {
req.on('end', common.mustCall());
res.end('hello world');
}));

server.unref();

server.listen(0, common.mustCall(() => {

const client = connect(server.address().port);

const req = [
'POST / HTTP/1.1',
`Host: localhost:${server.address().port}`,
'Connection: keep-alive',
'Content-Length: 11',
'',
'hello world',
''
].join('\r\n');

client.end(req);
}));