Skip to content

src,lib: expose memory file mapping flag #29260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaocgreis wants to merge 6 commits into from
Closed

src,lib: expose memory file mapping flag #29260

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2002dd1
src,lib: expose memory file mapping flag
joaocgreis Aug 21, 2019
a7146a3
fixup! src,lib: expose memory file mapping flag
joaocgreis Aug 22, 2019
b447c3c
fixup! src,lib: expose memory file mapping flag
joaocgreis Aug 22, 2019
45cea0b
fixup! src,lib: expose memory file mapping flag
joaocgreis Aug 22, 2019
c77569e
fixup! src,lib: expose memory file mapping flag
joaocgreis Sep 2, 2019
cc923d3
fixup! src,lib: expose memory file mapping flag
joaocgreis Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src,lib: expose memory file mapping flag
  • Loading branch information
@joaocgreis
joaocgreis committed Aug 22, 2019
commit 45cea0bde75ef3c8e25775eaa4158968f38dff16
4 changes: 1 addition & 3 deletions src/node_constants.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,9 +1127,7 @@ void DefineSystemConstants(Local<Object> target) {
NODE_DEFINE_CONSTANT(target, O_EXCL);
#endif

#ifdef UV_FS_O_FILEMAP
NODE_DEFINE_CONSTANT(target, UV_FS_O_FILEMAP);
#endif
NODE_DEFINE_CONSTANT(target, UV_FS_O_FILEMAP);

#ifdef O_NOCTTY
NODE_DEFINE_CONSTANT(target, O_NOCTTY);
Expand Down
4 changes: 4 additions & 0 deletions test/parallel/test-fs-open-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ assert.strictEqual(stringToFlags('max+'),
() => stringToFlags(flags),
{ code: 'ERR_INVALID_OPT_VALUE', type: TypeError }
);
common.expectsError(
() => stringToFlags(`m${flags}`),
{ code: 'ERR_INVALID_OPT_VALUE', type: TypeError }
);
});

common.expectsError(
Expand Down