Skip to content

console: display timeEnd with suitable time unit #29251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xstoudi wants to merge 9 commits into from
Closed

console: display timeEnd with suitable time unit #29251

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b00bdf6
console: display timeEnd with suitable time unit
Xstoudi Aug 21, 2019
c4eb2d6
console: extract formatTime and export it for test
Xstoudi Aug 21, 2019
dc97305
test: adapt tests
Xstoudi Aug 21, 2019
106bbd4
console: don't trim formatTime value before returning it
Xstoudi Aug 21, 2019
510ef86
test: adapt formatTime tests to previous commit
Xstoudi Aug 21, 2019
57bbc6c
console: fix linter
Xstoudi Aug 21, 2019
c5063d0
test: fix linter
Xstoudi Aug 21, 2019
368e5d7
console: move magic numbers to constants
Xstoudi Aug 22, 2019
da4e02f
test: add blank line
Xstoudi Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
console: move magic numbers to constants 
Hour, minute and second equivalent in ms are now constants.
  • Loading branch information
@Xstoudi
Xstoudi committed Aug 23, 2019
commit 368e5d7d3e1609ac5e85cf9bc7ab29a6ca10ee44
16 changes: 10 additions & 6 deletions lib/internal/console/constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ const kTraceBegin = 'b'.charCodeAt(0);
const kTraceEnd = 'e'.charCodeAt(0);
const kTraceInstant = 'n'.charCodeAt(0);

const kSecond = 1000;
const kMinute = 60 * kSecond;
const kHour = 60 * kMinute;

const {
isArray: ArrayIsArray,
from: ArrayFrom,
Expand Down Expand Up @@ -533,14 +537,14 @@ function formatTime(ms) {
let value = ms;
let unit = 'ms';

if (ms >= 3600000) {
value = ms / 3600000;
if (ms >= kHour) {
value = ms / kHour;
unit = 'h';
} else if (ms >= 60000) {
value = ms / 60000;
} else if (ms >= kMinute) {
value = ms / kMinute;
unit = 'min';
} else if (ms >= 1000) {
value = ms / 1000;
} else if (ms >= kSecond) {
value = ms / kSecond;
unit = 's';
}

Expand Down