Skip to content

[x] stream: don't emit finish after destroy() #29205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

[x] stream: don't emit finish after destroy() #29205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dc4f94
stream: don't emit finish after destroy()
ronag Aug 19, 2019
4df3c3e
stream: consistent clearBuffer
ronag Aug 19, 2019
8add970
stream: move condition into clearBuffer
ronag Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
stream: don't emit finish after destroy() 
When destroying the stream will be potentially incomplete and
therefore it doesn't make sense to emit finish.
  • Loading branch information
@ronag
ronag committed Aug 20, 2019
commit 0dc4f9422cff897a62e2eceda2bf192e4d7babd6
3 changes: 2 additions & 1 deletion lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,8 @@ function needFinish(state) {
state.length === 0 &&
state.bufferedRequest === null &&
!state.finished &&
!state.writing);
!state.writing &&
!state.destroyed);
}
function callFinal(stream, state) {
stream._final((err) => {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-stream-writable-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const assert = require('assert');
write.destroy();

write.removeListener('finish', fail);
write.on('finish', common.mustCall());
write.on('finish', common.mustNotCall());
assert.strictEqual(write.destroyed, true);
}

Expand Down