Skip to content

build: add a testclean target#29094

Closed
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:build-add-testclean-target
Closed

build: add a testclean target#29094
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:build-add-testclean-target

Conversation

@danbev

@danbev danbev commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the clean target.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 12, 2019

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to vcbuild.bat too?

@danbev

danbev commented Aug 14, 2019

Copy link
Copy Markdown
Contributor Author

Can you add this to vcbuild.bat too?

I'll take a look at adding this to vcbuild.bat today. Thanks

@Trott

Trott commented Aug 14, 2019

Copy link
Copy Markdown
Member

Can you add this to vcbuild.bat too?

I'll take a look at adding this to vcbuild.bat today. Thanks

Looks like vcbuild.bat never cleans tmp directories, even if vcbuild.bat clean is called, so this would be adding new additional functionality to vcbuild.bat beyond what is being added to Makefile here. I'm not even sure that we put the tmp directories in the same place on Windows as we do on POSIX. I'm OK leaving this off. Someone can implement it later if it's desirable to have on Windows too.

@Trott

Trott commented Aug 14, 2019

Copy link
Copy Markdown
Member

I'm not even sure that we put the tmp directories in the same place on Windows as we do on POSIX.

(We do.)

@danbev

danbev commented Aug 16, 2019

Copy link
Copy Markdown
Contributor Author

@Trott I've added a testclean target which can be called using:

danbev@win2 MINGW64 ~/node (master)
$ ./vcbuild.bat testclean
deleting test/.tmp*

Sorry this took so long, I had to set up a windows vm on azure as I had deleted my local window vm due to resource constraints.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Trott pushed a commit that referenced this pull request Aug 16, 2019
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.

PR-URL: #29094
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Aug 16, 2019

Copy link
Copy Markdown
Member

Landed in a890771

@Trott Trott closed this Aug 16, 2019
targos pushed a commit that referenced this pull request Aug 19, 2019
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.

PR-URL: #29094
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danbev danbev deleted the build-add-testclean-target branch August 20, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants