Skip to content

test: unskip tests that now pass on AIX #29054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 1 commit into from
Closed

test: unskip tests that now pass on AIX #29054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: unskip tests that now pass on AIX 
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)
  • Loading branch information
@sam-github
sam-github committed Aug 9, 2019
commit 79548b9cd48f78664f2881ff04778a55652fc53c
2 changes: 0 additions & 2 deletions test/message/message.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,3 @@ prefix message
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
vm_dont_display_syntax_error: SKIP
3 changes: 1 addition & 2 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ test-http2-large-file: PASS, FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
test-async-wrap-getasyncid: SKIP
# https://github.com/nodejs/node/pull/29054
test-buffer-creation-regression: SKIP

[$arch==arm]