Skip to content

[v10.x] backport #26599 (process: add --unhandled-rejections flag) #29036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

[v10.x] backport #26599 (process: add --unhandled-rejections flag) #29036

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7ff5ea
process: add --unhandled-rejections flag
BridgeAR Mar 11, 2019
26d3b0a
worker: add missing return value in case of fatal exceptions
BridgeAR Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
worker: add missing return value in case of fatal exceptions 
This adds a missing return value for the worker specific fatal
exception handler.
  • Loading branch information
@BridgeAR
BridgeAR committed Sep 24, 2019
commit 26d3b0a757c91614f2a42dba3da9f67a99689044
34 changes: 18 additions & 16 deletions lib/internal/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,23 +489,25 @@ function setupChild(evalScript) {
}
debug(`[${threadId}] fatal exception caught = ${caught}`);

if (!caught) {
let serialized;
try {
serialized = serializeError(error);
} catch {}
debug(`[${threadId}] fatal exception serialized = ${!!serialized}`);
if (serialized)
port.postMessage({
type: messageTypes.ERROR_MESSAGE,
error: serialized
});
else
port.postMessage({ type: messageTypes.COULD_NOT_SERIALIZE_ERROR });
clearAsyncIdStack();

process.exit();
if (caught) {
return true;
}

let serialized;
try {
serialized = serializeError(error);
} catch {}
debug(`[${threadId}] fatal exception serialized = ${!!serialized}`);
if (serialized)
port.postMessage({
type: messageTypes.ERROR_MESSAGE,
error: serialized
});
else
port.postMessage({ type: messageTypes.COULD_NOT_SERIALIZE_ERROR });
clearAsyncIdStack();

process.exit();
}
}

Expand Down