Skip to content

assert.deepEqual: fix bug with faked boxed primitives #29029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ljharb wants to merge 3 commits into from
Closed

assert.deepEqual: fix bug with faked boxed primitives #29029

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7759ff9
test: assert: add failing deepEqual test for faked boxed primitives
ljharb Aug 6, 2019
9f53778
util: assert: fix deepEqual comparing fake-boxed to real boxed primitive
ljharb Aug 6, 2019
d90707a
util: isEqualBoxedPrimitive: ensure both values are actual boxed Symbols
ljharb Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
util: isEqualBoxedPrimitive: ensure both values are actual boxed Symbols 
... before trying to valueOf them
  • Loading branch information
@ljharb
ljharb committed Aug 7, 2019
commit d90707a8c5821bd38d9dd3efcce9eae984c343d7
7 changes: 5 additions & 2 deletions lib/internal/util/comparisons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,11 @@ function isEqualBoxedPrimitive(val1, val2) {
return isBigIntObject(val2) &&
BigIntPrototype.valueOf(val1) === BigIntPrototype.valueOf(val2);
}
return isSymbolObject(val2) &&
SymbolPrototype.valueOf(val1) === SymbolPrototype.valueOf(val2);
if (isSymbolObject(val1)) {
return isSymbolObject(val2) &&
SymbolPrototype.valueOf(val1) === SymbolPrototype.valueOf(val2);
}
return false;
}

// Notes: Type tags are historical [[Class]] properties that can be set by
Expand Down