Skip to content

[x] stream: async iterate don't register listeners if ended #28996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 1 commit into from
Closed

[x] stream: async iterate don't register listeners if ended #28996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
stream: don't register listeners if ended
  • Loading branch information
@ronag
ronag committed Aug 9, 2019
commit 1a8c9c2c07c855121c2f97859dc6c93d0b5e835b
4 changes: 4 additions & 0 deletions lib/internal/streams/async_iterator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ const createReadableStreamAsyncIterator = (stream) => {
});
iterator[kLastPromise] = null;

if (iterator[kEnded]) {
return iterator;
}

finished(stream, { writable: false }, (err) => {
if (err && err.code !== 'ERR_STREAM_PREMATURE_CLOSE') {
const reject = iterator[kLastReject];
Expand Down