Skip to content

doc: remove use of you #28919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 1 commit into from
Closed

doc: remove use of you #28919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: remove use of you 
We generally avoid the use of 'you'.
  • Loading branch information
@mhdawson
mhdawson committed Aug 1, 2019
commit 5774846fd4656896b83038544481f010c0f4cd42
4 changes: 2 additions & 2 deletions doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ available to the module code.

N-API versions are additive and versioned independently from Node.js.
Version 4 is an extension to version 3 in that it has all of the APIs
Copy link
Copy Markdown
Member

@Trott Trott Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version 4 is an extension to version 3 in that it has all of the APIs
Version 4 is an extension to version 3 in that it has all the APIs

from version 3 with some additions. This means that you
do not need to recompile for new versions of Node.js which are
from version 3 with some additions. This means that it is not necessary
to recompile for new versions of Node.js which are
listed as supporting a later version.

| | 1 | 2 | 3 | 4 |
Expand Down