Skip to content

inspector: report all workers #28872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eugeneo wants to merge 5 commits into from
Closed

inspector: report all workers #28872

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cbf72e
inspector: report all workers
eugeneo Jul 26, 2019
337bc4a
squash: address code review comments
Jul 28, 2019
16eee7a
squash: do not use NodeWorker domain in a worker.
eugeneo Jul 29, 2019
fdd7a24
fixup
Trott Jul 29, 2019
d804348
fixup
Trott Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address code review comments
  • Loading branch information
Eugene Ostroukhov committed Jul 28, 2019
commit 337bc4a53df2822c661c784c0804cb7d7d6e1a3e
21 changes: 11 additions & 10 deletions test/parallel/test-inspector-workers-flat-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,19 @@ const MAX_DEPTH = 3;

let rootWorker = null;

function runTest() {
const runTest = common.mustCall(function() {
let reportedWorkersCount = 0;
const session = new Session();
session.connect();
session.on('NodeWorker.attachedToWorker', ({ params: { workerInfo } }) => {
console.log(`Worker ${workerInfo.title} was reported`);
if (++reportedWorkersCount === MAX_DEPTH) {
rootWorker.postMessage({ done: true });
}
});
session.on('NodeWorker.attachedToWorker', common.mustCall(
({ params: { workerInfo } }) => {
console.log(`Worker ${workerInfo.title} was reported`);
if (++reportedWorkersCount === MAX_DEPTH) {
rootWorker.postMessage({ done: true });
}
}, MAX_DEPTH));
session.post('NodeWorker.enable', { waitForDebuggerOnStart: false });
}
});

function processMessage({ child }) {
console.log(`Worker ${child} is running`);
Expand All @@ -44,7 +45,7 @@ function runMainThread() {
rootWorker = startWorker(1, processMessage);
}

function runWorkerThread() {
function runChildWorkerThread() {
let worker = null;
Copy link
Copy Markdown
Member

@addaleax addaleax Jul 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to child or childWorker to be more explicit?

Copy link
Copy Markdown
Contributor Author

@eugeneo eugeneo Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

parentPort.on('message', ({ child, depth, done }) => {
if (done) {
Expand All @@ -66,5 +67,5 @@ function runWorkerThread() {
if (isMainThread) {
runMainThread();
} else {
runWorkerThread();
runChildWorkerThread();
}