Skip to content

stream: resolve perf regression introduced by V8 7.3 #28842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 3 commits into from
Closed

stream: resolve perf regression introduced by V8 7.3 #28842

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6e108a
stream: resolve perf regression introduced by V8 7.3
mcollina Jul 24, 2019
0b015f8
Update lib/_stream_writable.js
mcollina Jul 24, 2019
14bc169
Update lib/_stream_readable.js
mcollina Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/_stream_writable.js 
Co-Authored-By: mscdex <mscdex@users.noreply.github.com>
  • Loading branch information
@mcollina @mscdex
mcollina and mscdex authored Jul 24, 2019
commit 0b015f804a77cdceef92e974f40a52af1168e9dd
2 changes: 1 addition & 1 deletion lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ Writable.prototype.write = function(chunk, encoding, cb) {
var ret = false;
const isBuf = !state.objectMode && Stream._isUint8Array(chunk);

// Do not use Object.getPrototypeOf as it is slower.
// Do not use Object.getPrototypeOf as it is slower since V8 7.3.
if (isBuf && !(chunk instanceof Buffer)) {
chunk = Stream._uint8ArrayToBuffer(chunk);
}
Expand Down