Skip to content

[x] stream: eos avoid listeners when possible #28751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

[x] stream: eos avoid listeners when possible #28751

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
feaa7a3
stream: eos avoid listeners when not legacy compat
ronag Jul 18, 2019
07a93a0
stream: conditionally create legacy handlers
ronag Jul 30, 2019
d213f7a
stream: prefer let over var
ronag Jul 30, 2019
edb7e47
stream: conditionally create error handler
ronag Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stream: prefer let over var
  • Loading branch information
@ronag
ronag committed Aug 21, 2019
commit d213f7adb4e93208cbb79b2ffbaabf8ee089559e
4 changes: 2 additions & 2 deletions lib/internal/streams/end-of-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ function eos(stream, opts, callback) {
const isLegacyWritable = typeof stream.writableFinished !== 'boolean' &&
writable && !stream._writableState;

var writableEnded = stream._writableState && stream._writableState.finished;
let writableEnded = stream._writableState && stream._writableState.finished;
const onfinish = () => {
writable = false;
writableEnded = true;
if (!readable) callback.call(stream);
};

var readableEnded = stream.readableEnded ||
let readableEnded = stream.readableEnded ||
(stream._readableState && stream._readableState.endEmitted);
const onend = () => {
readable = false;
Expand Down