Skip to content

doc: deprecate finished #28679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 12 commits into from
Closed

doc: deprecate finished #28679

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ff98ad5
doc: deprecate http finished
ronag Jul 14, 2019
e1408d3
fixup
ronag Sep 19, 2019
fffc596
fixup
ronag Sep 19, 2019
53add50
fixup
ronag Sep 19, 2019
4d8bfdf
Update doc/api/deprecations.md
ronag Nov 19, 2019
7b70641
Update doc/api/deprecations.md
ronag Nov 19, 2019
39be20a
Update doc/api/deprecations.md
ronag Nov 19, 2019
2fa2ec6
fixup
ronag Nov 19, 2019
11337b6
Update doc/api/deprecations.md
ronag Nov 20, 2019
dcd3724
fixup: ref
ronag Nov 20, 2019
476d612
Update doc/api/deprecations.md
ronag Dec 7, 2019
60c6119
Update doc/api/deprecations.md
ronag Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update doc/api/deprecations.md 
Co-Authored-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@ronag @BridgeAR
ronag and BridgeAR authored Dec 10, 2019
commit 60c6119dc28bc50d0833ddfd702b72195f210aae
2 changes: 1 addition & 1 deletion doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2531,7 +2531,7 @@ Type: Documentation-only

[`response.finished`][] indicates whether [`response.end()`][] has been
called, not whether `'finish'` has been emitted and the underlying data
is flushed,
is flushed.

Use [`response.writableFinished`][] or [`response.writableEnded`][]
accordingly instead to avoid the ambigiuty.
Expand Down