Skip to content

http: reset parser.incoming when server response is finished #28646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

http: reset parser.incoming when server response is finished #28646

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
609e2c2
http: reset parser.incoming when server response is finished
addaleax Jul 11, 2019
da10b34
fixup! http: reset parser.incoming when server response is finished
addaleax Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http: reset parser.incoming when server response is finished 
This resolves a memory leak for keep-alive connections with a naïve
approach.

Fixes: #9668
  • Loading branch information
@addaleax
addaleax committed Jul 11, 2019
commit 609e2c2e87d1d8e5bd3dda69913f22117a5650d1
1 change: 1 addition & 0 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,7 @@ function resOnFinish(req, res, socket, state, server) {
assert(state.incoming.length === 0 || state.incoming[0] === req);

state.incoming.shift();
if (socket.parser) socket.parser.incoming = null;
Comment thread
addaleax marked this conversation as resolved.

// If the user never called req.read(), and didn't pipe() or
// .resume() or .on('data'), then we call req._dump() so that the
Expand Down