Skip to content

deps: cherry-pick ARM64 Windows changes to node-gyp #28604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkunkee wants to merge 2 commits into from
Closed

deps: cherry-pick ARM64 Windows changes to node-gyp #28604

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd204c
deps: cherry-pick 721dc7d from node-gyp upstream
jkunkee Jul 10, 2019
c51ec2b
deps: cherry-pick 91744bf from node-gyp upstream
jkunkee Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: cherry-pick 91744bf from node-gyp upstream 
This change cherry-picks a small set of node-gyp v5.0.0 changes needed
to enable Node.js ARM64 Windows builds.

Original commit message:
  gyp: add support for Windows on Arm

  Cherry-pick of refack/GYP3#33, supersedes
  nodejs/node-gyp#1678 until GYP3 is merged.

  `npm test` passes

  Change-Id: I2b1e1e03e378b4812d34afa527087793864d1576

  PR-URL: nodejs/node-gyp#1739
  Reviewed-By: Refael Ackermann <refack@gmail.com>
  Reviewed-By: João Reis <reis@janeasystems.com>

Refs: nodejs/node-gyp@91744bf
PR-URL: #28604
  • Loading branch information
@jkunkee @joaocgreis
jkunkee authored and joaocgreis committed Jul 11, 2019
commit c51ec2b04c52dfea8c8a36b41f06b78c6cf732b6
4 changes: 3 additions & 1 deletion deps/npm/node_modules/node-gyp/gyp/pylib/gyp/MSVSSettings.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions deps/npm/node_modules/node-gyp/gyp/pylib/gyp/generator/msvs.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 13 additions & 4 deletions deps/npm/node_modules/node-gyp/gyp/pylib/gyp/msvs_emulation.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions deps/npm/node_modules/node-gyp/lib/configure.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.