Skip to content

test: skip external-exceed-max-by-1-hex on AIX #28516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 2 commits into from
Closed

test: skip external-exceed-max-by-1-hex on AIX #28516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c57272
test: skip stringbytes-external-exceed-max on AIX
sam-github Jul 2, 2019
8567f2a
fixup! test: skip stringbytes-external-exceed-max on AIX
sam-github Jul 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: skip stringbytes-external-exceed-max on AIX 
Add SKIP status for more tests in stringbytes-external-exceed-max that
are failing on AIX.
  • Loading branch information
@sam-github
sam-github committed Jul 4, 2019
commit 4c5727271e8b910c31bcb2e650f7b5eb937c4301
12 changes: 12 additions & 0 deletions test/addons/addon.status
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
prefix addons

[true] # This section applies to all platforms

[$system==aix]
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
# https://github.com/nodejs/node/pull/28469
# https://github.com/nodejs/node/pull/28516
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js: SKIP

# https://github.com/nodejs/node/pull/28516
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: SKIP
5 changes: 0 additions & 5 deletions test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem)
common.skip(skipMessage);

// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
// See https://github.com/nodejs/node/pull/28469
if (process.platform === 'aix')
common.skip('flaky on AIX');

const binding = require(`./build/${common.buildType}/binding`);

// v8 fails silently if string length > v8::String::kMaxLength
Expand Down