Skip to content

Increase limit for network space overhead test #28492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
titzer wants to merge 1 commit into from
Closed

Increase limit for network space overhead test #28492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Increase limit for network space overhead test 
This test imposes a limit on the average bytes of space per chunk for network traffic. However this number depends on VM implementation details, and upcoming changes to V8's array buffer management require a small bump to this limit in this test.
  • Loading branch information
Ben L. Titzer authored Jul 1, 2019
commit 3bafd5b6fec10589d130146a6c2cd1a18384cef2
2 changes: 1 addition & 1 deletion test/sequential/test-net-bytes-per-incoming-chunk-overhead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ process.on('exit', () => {
const bytesPerChunk =
(process.memoryUsage().rss - baseRSS) / receivedChunks.length;
// We should always have less than one page (usually ~ 4 kB) per chunk.
assert(bytesPerChunk < 512, `measured ${bytesPerChunk} bytes per chunk`);
assert(bytesPerChunk < 600, `measured ${bytesPerChunk} bytes per chunk`);
});