Skip to content

doc: add example function isDead to cluster #28362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jessecogollo wants to merge 5 commits into from
Closed

doc: add example function isDead to cluster #28362

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52d6aac
doc: add example function isDead to cluster
jessecogollo Jun 21, 2019
7743c84
remove blank line
jessecogollo Jun 21, 2019
41572de
remove blank line
jessecogollo Jun 21, 2019
d744b49
remove blank line
jessecogollo Jun 21, 2019
690289b
fix typo
jessecogollo Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove blank line
  • Loading branch information
@jessecogollo
jessecogollo committed Jun 21, 2019
commit 7743c8470a1e669c7895945d25827a43fec0348d
1 change: 0 additions & 1 deletion doc/api/cluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,6 @@ if (cluster.isMaster) {
res.end(`Current process\n ${process.pid}`);
process.kill(process.pid);
}).listen(8000);

// Make http://localhost:8000 to ckeck isDead method.
Copy link
Copy Markdown
Member

@trivikr trivikr Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo

Suggested change
// Make http://localhost:8000 to ckeck isDead method.
// Make http://localhost:8000 to check isDead method.

Copy link
Copy Markdown
Member

@Trott Trott Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Make" means "Make a connection to" here?

Suggested change
// Make http://localhost:8000 to ckeck isDead method.
// Connect to http://localhost:8000 to check isDead().

Copy link
Copy Markdown
Contributor Author

@jessecogollo jessecogollo Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Trott and @trivikr typo is fixed. Let me know other comment 😉

}

Comment thread
BridgeAR marked this conversation as resolved.
Outdated
Expand Down