Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v12.5.0 proposal #28268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
v12.5.0 proposal #28268
Changes from 1 commit
86a8bb721bcfb65101e4c018159d4a61bdbca8e5aa2f92b1555e99448b8fe87fa6dfec445bb81c08d94bb4111140a5ff4cf8a33abbb729a4e4aa869ad3a164ab1a4eb92d1ca940a1a11f8c9a5870f8e71c086736c20c6e5e8bedd2e5c2675dfbbfbb7165254d81c67b79d4f28049429bdf22b96e3f905ad42ad64687e57f1f2de2f686cb13ad4225892096984155bba03b92e95ac6ddd27d6b2898f7ae9f41dfd7ee62fa1af9eb96a0d2862328b2d0d2585048e282592331e9c9dd840d62de36e9dd48131ef281195ee3b5b6bdf75f336236e08a98f098cf743feaf3d87e977a87c55eaf7d8384c821eefeb73ed8f95a52c9074f9b5ad0d04eb05db9b690e19f897860d4bb88e460cc62a5fdedbc3243dee6ecc13dfdf7428a032fc8849eb2d1c53fc3f1787bb491eab5fc4e48d7641d879a8cd0e1fc9b907169448984b7314bd26cadb01977ae23ab96848429de9d5522bbdc57d1f15f8670f6de673b57f9ddcc6d757e0b5d0737778f39c974e6109c82023a94a6d7a189d6afb0bc23cd6791d1d8061dc186e94c360c70856b150b9ced33469af43e705f259adfbd36739c2a39be67b252564dbbf768236460d07a0c5b5860144299382b3b2353c63d320791de6627f31ccd3600e6c9d084ffd8318328f4d6262f8c27755ecb963d1ee7ce682174418157a50ef8f147f03241fabe5d05b5dda32c67642a303a9a36b9d47748d7d7c5a7154e613064681a1a1358eccb1a3f8385bd16f9b694faf1a599815a40cfb34cadddcdf9b25302fdf5ceb89c066a2d8e2dba59835ee6ecd9b248e34eaac83029b50d2515df09edf69539b10abaeda0c332b080343fa8247cf79fa6015627aa3c41f7e61760b6f113bddef3d09419daf9c7ea2c9ea74b7faeed80174b3c4b60287d9c19c4bd659ed67044a7a8aeb9cc47366d701b404fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Original commit message: Remove recursion from NeedsCheckHeapObject. We use the predicate NeedsCheckHeapObject in the compiler frontend to determine whether we can skip introducing CheckHeapObject nodes. But this predicate would also walk up the graph in case of Phis, which can result in really long compilation times (on the main thread). In the report in #27667, the compiler frontend alone took around 4-5mins of main thread time for a single function. With this patch the time goes down to 4-5ms. Bug: v8:9250 Refs: #27667 Change-Id: I231eb780ff04f949fa1669714f9af6ebfbcade05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612897 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61503} Fixes: #27667 Backport-PR-URL: #28005 PR-URL: #27729 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing