Skip to content

doc: Updating Table of Content in Building.md #28264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rowlandjumbo wants to merge 2 commits into from
Closed

doc: Updating Table of Content in Building.md #28264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130750b
Updating Table of Content in Building.md
rowlandjumbo Jun 17, 2019
bbdcc25
Linked 'Prerequisites' for Unix/macOS and Windows
rowlandjumbo Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updating Table of Content in Building.md 
1. First time user (like me) could not see the instruction to install all
prerequisites using the bootstrapping guide because it was not
properly linked in the table of contents.

2. The 'Prerequisites' link in the table of content links only to the
'prerequisites' for Unix/macOS skipping over the 'prerequisites' section
that refers to the bootstrapping guide.

I added a new link to the section that refers to the bootstrapping guide
called it 'Installing Prerequisites' and removed the link to the prerequisite
under Unix/macOS section. Now both Unix/macOS and the Windows
section do not have their prerequisites in the 'table of contents'. Initially,
only Unix/macOS had.
  • Loading branch information
@rowlandjumbo
rowlandjumbo authored Jun 17, 2019
commit 130750be7b77b6517ead8bf876d3cf9b024562e5
5 changes: 3 additions & 2 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ file a new issue.
* [OpenSSL asm support](#openssl-asm-support)
* [Previous versions of this document](#previous-versions-of-this-document)
* [Building Node.js on supported platforms](#building-nodejs-on-supported-platforms)
* [Installing Prerequisites](#installing-prerequisites)
* [Unix/macOS](#unixmacos)
* [Prerequisites](#prerequisites)
* [Building Node.js](#building-nodejs)
* [Running Tests](#running-tests)
* [Running Coverage](#running-coverage)
Expand Down Expand Up @@ -215,12 +215,13 @@ Consult previous versions of this document for older versions of Node.js:

## Building Node.js on supported platforms

#### Installing Prerequisites
The [bootstrapping guide](https://github.com/nodejs/node/blob/master/tools/bootstrap/README.md)
explains how to install all prerequisites.

### Unix/macOS

#### Prerequisites
Prerequisites:
Comment thread
rowlandjumbo marked this conversation as resolved.
Outdated

* `gcc` and `g++` >= 6.3 or newer, or
* macOS: Xcode Command Line Tools >= 8
Expand Down