Skip to content

build: re-enable custom V8 snapshot by default #28181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

build: re-enable custom V8 snapshot by default #28181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d917d3
tools: assert that the snapshot can be rehashed in node_mksnapshot
joyeecheung Jun 11, 2019
c1a2c64
build: turn on custom V8 snapshot by default
joyeecheung Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: assert that the snapshot can be rehashed in node_mksnapshot
  • Loading branch information
@joyeecheung
joyeecheung committed Jun 11, 2019
commit 7d917d3be4422e218ce9b981c821167a33ec4f8a
1 change: 1 addition & 0 deletions tools/snapshot/snapshot_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ std::string SnapshotBuilder::Generate(
// Must be out of HandleScope
StartupData blob =
creator.CreateBlob(SnapshotCreator::FunctionCodeHandling::kClear);
CHECK(blob.CanBeRehashed());
// Must be done while the snapshot creator isolate is entered i.e. the
// creator is still alive.
main_instance->Dispose();
Expand Down