Skip to content

build: unbreak --with-intl=system-icu build #28118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 3 commits into from
Closed

build: unbreak --with-intl=system-icu build #28118

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa5e4cc
build: don't swallow pkg-config warnings
bnoordhuis Jun 7, 2019
1a62bc8
build: fix icu-i18n pkg-config version check
bnoordhuis Jun 7, 2019
167f4b0
build: unbreak --with-intl=system-icu build
bnoordhuis Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: fix icu-i18n pkg-config version check 
The pkg_config() helper can either return a tuple of None values
(no pkg-config installed) and that was what the check was testing
for, but it can also return a tuple of empty strings when the
package isn't installed.
  • Loading branch information
@bnoordhuis
bnoordhuis committed Jun 7, 2019
commit 1a62bc8056bf813f5825b149ba68696476c39699
2 changes: 1 addition & 1 deletion configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,7 +1348,7 @@ def write_config(data, name):
# ICU from pkg-config.
o['variables']['v8_enable_i18n_support'] = 1
pkgicu = pkg_config('icu-i18n')
if pkgicu[0] is None:
if not pkgicu[0]:
error('''Could not load pkg-config data for "icu-i18n".
See above errors or the README.md.''')
(libs, cflags, libpath, icuversion) = pkgicu
Expand Down