Skip to content

build: more portable Makefile #28108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 4 commits into from
Closed

build: more portable Makefile #28108

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ee79a8
build: more portable Makefile
refack Jun 6, 2019
2f36e5d
fixup!
refack Jun 6, 2019
0d18772
squash! more normalization
refack Jun 6, 2019
b4a589a
fixup! keep output of lint-js.js in TAP
refack Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! keep output of lint-js.js in TAP
  • Loading branch information
@refack
refack committed Jun 6, 2019
commit b4a589a0e2b654f0ffec261fd2a98f3c5ece834e
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,11 +1214,11 @@ lint-js:
jslint: lint-js
$(info Please use lint-js instead of jslint)

# For CI use local compiled 'node', and output in xUnit (junit) format.
# For CI use local compiled 'node', and output in TAP format.
.PHONY: lint-js-ci
lint-js-ci:
$(info Running JS linter...)
./node tools/lint-js.js $(PARALLEL_ARGS) -f junit -o test-eslint.xml $(LINT_JS_TARGETS)
./node tools/lint-js.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap $(LINT_JS_TARGETS)

jslint-ci: lint-js-ci
$(info Please use lint-js-ci instead of jslint-ci)
Expand Down