Skip to content

doc: add Buffer#subarray() and add note about Uint8Array#slice() #28101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gfx wants to merge 6 commits into from
Closed

doc: add Buffer#subarray() and add note about Uint8Array#slice() #28101

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a00c5b
doc: add Buffer#subarray() and add note about Uint8Array#slice()
gfx Jun 6, 2019
07e7c7d
Update doc/api/buffer.md
gfx Jun 10, 2019
21e452f
Update doc/api/buffer.md
gfx Jun 10, 2019
70271da
Update doc/api/buffer.md
gfx Jun 11, 2019
eb5efd9
Update doc/api/buffer.md
gfx Jun 11, 2019
54c4949
Update doc/api/buffer.md
gfx Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api/buffer.md 
Co-Authored-By: Anna Henningsen <github@addaleax.net>
  • Loading branch information
@gfx @addaleax
gfx and addaleax authored Jun 10, 2019
commit 07e7c7dd4632dab9b14011dca21cfc6ffc05595a
4 changes: 3 additions & 1 deletion doc/api/buffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1977,7 +1977,9 @@ offset and cropped by the `start` and `end` indices.

This is the same behavior as `buf.subarray()`.

Note that this method is not compatible with the `Uint8Array#slice()`, which is a superclass of `Buffer`. If a copy of slice is needed, use `Uint8Array.prototype.slice` directly.
Note that this method is not compatible with the `Uint8Array.prototype.slice()`,
Comment thread
gfx marked this conversation as resolved.
Outdated
which is a superclass of `Buffer`. If a copy of the slice is needed, use
Comment thread
gfx marked this conversation as resolved.
Outdated
`Uint8Array.prototype.slice` directly.
Comment thread
gfx marked this conversation as resolved.
Outdated

```js
const buf = Buffer.from('buffer');
Expand Down