Skip to content

process: improve queueMicrotask performance #28093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 3 commits into from
Closed

process: improve queueMicrotask performance #28093

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25af820
process: improve queueMicrotask performance
apapirovski Jun 6, 2019
dcb3675
fixup: avoid ReflectApply ugliness
apapirovski Jun 6, 2019
76e1185
fixup: remove the other weirdness
apapirovski Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: avoid ReflectApply ugliness
  • Loading branch information
@apapirovski
apapirovski committed Jun 6, 2019
commit dcb367596cdc310376c9f629de2c782576438fc9
5 changes: 3 additions & 2 deletions lib/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const { Reflect } = primordials;
const ReflectApply = Reflect.apply;

const {
ERR_ASYNC_CALLBACK,
Expand Down Expand Up @@ -169,7 +168,9 @@ class AsyncResource {
const asyncId = this[async_id_symbol];
emitBefore(asyncId, this[trigger_async_id_symbol]);
try {
return ReflectApply(fn, thisArg, args);
if (thisArg === undefined)
return fn(...args);
return Reflect.apply(fn, thisArg, args);
} finally {
emitAfter(asyncId);
}
Expand Down